Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chromedriver download url changing for versions 115+ #416

Closed
benm071 opened this issue Jun 5, 2023 · 3 comments
Closed

Chromedriver download url changing for versions 115+ #416

benm071 opened this issue Jun 5, 2023 · 3 comments
Assignees

Comments

@benm071
Copy link

benm071 commented Jun 5, 2023

Chrome has changed their download site/formats as of 115 to something like

https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/115.0.5790.13/win32/chromedriver-win32.zip

Therefore, the built in googleapis site no longer works, and it's not seemingly possible to use the environment variables to create a compatible URL. The closest we can come is to define, for example:

CHROMEDRIVER_CDNURL=https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/115.0.5790.13

and

CHROMEDRIVER_VERSION=win32

however the target filename on the Chrome CDN has now been changed to
chromedriver-win32.zip rather than the
chromeidriver_win32.zip built into node-chromedriver. (Note the change from _ to -)
I don't think this can be overcome without a node-chromedriver code change

A patch needs to be released for node-chromedriver that either can build the proper CDN URL for chromedrivers after 114 or allow a configurable target CDN filename to be overridden using an environment variable so we can hack together the proper download.

See https://groups.google.com/g/chromedriver-users/c/clpipqvOGjE

@giggio
Copy link
Owner

giggio commented Jun 5, 2023

Thanks for the heads up, @benm071! I have posted a question there to clear some points. After those are answered and can move forward and change the install script to work with 115+ versions, which are not out yet (and are planned only to mid-July).

@giggio giggio self-assigned this Jun 5, 2023
@giggio giggio changed the title Downloads for chromedriver no longer work as of versions 115+ Chromedriver download url changing for versions 115+ Jun 5, 2023
@giggio giggio closed this as completed in 61189b2 Jun 10, 2023
@giggio
Copy link
Owner

giggio commented Jun 10, 2023

@benm071 I changed the code to work with both versions up to 114 (using the current and now being phased out urls) and the new ones that start with 115. You can already try it by specifying the version, there are several ways to do it. It was published as 114.0.2.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants