Fix installation on Clang-15 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Fix finding of libFuzzer static library. 2. Fix finding of ASan and UBSan static libraries.
jonathanmetzman
commented
Aug 4, 2022
setup_utils/find_libfuzzer.sh
Outdated
| @@ -24,11 +24,11 @@ if [[ "$uname" == "Darwin" ]]; then | |||
| elif [[ "$uname" == "Linux" ]]; then | |||
| machine="$(uname -m)" | |||
| if [[ "$machine" == "x86_64" ]]; then | |||
There was a problem hiding this comment.
Note: I haven't fixed OSX because I have no way to test this or determine the triple correctly.
setup_utils/find_libfuzzer.sh
Outdated
| @@ -24,11 +24,11 @@ if [[ "$uname" == "Darwin" ]]; then | |||
| elif [[ "$uname" == "Linux" ]]; then | |||
| machine="$(uname -m)" | |||
| if [[ "$machine" == "x86_64" ]]; then | |||
| libpath="lib/linux/libclang_rt.fuzzer_no_main-x86_64.a" | |||
| libpath="lib/x86_64-unknown-linux-gnu/libclang_rt.fuzzer_no_main.a" | |||
There was a problem hiding this comment.
I frankly don't need the changes in this file for OSS-Fuzz, I can hack around this files problems with LIBFUZZER_LIB. I'm happy to undo my changes to this file and let you figure out how to handle the differences between clang versions.
|
This will break builds with earlier versions of LLVM. Per discussion offline, Jonathan will post a partial change that allows clang-15 to work with LIBFUZZER_LIB. We'll make it automatic at a later point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix finding of ASan and UBSan static libraries.
Fixes: #36