Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel build doesn't set correct compile flags. #430

Closed
plmuon opened this issue Feb 14, 2019 · 0 comments
Closed

Bazel build doesn't set correct compile flags. #430

plmuon opened this issue Feb 14, 2019 · 0 comments

Comments

@plmuon
Copy link
Contributor

plmuon commented Feb 14, 2019

We're using the bazel build (bazel/glog.bzl).
It contains 2 genrules that generate some of the header files.
In addition, it has a build rule (native.cc_library) that compiles the source (using the generated header files) with -D flags. These flags are fixed in the rule and not derived from the system (like with the cmake build or autogen/configure/make.

Amongst others, -DHAVE_UNISTD_H is not defined. This results in symlinks not being created.

For our local build, I have now overridden the bazel build file and added a few flags that are appropriate to our environment manually, which is only a workaround for our local context:
"-DHAVE_UNISTD_H",
"-DHAVE_PWD_H",
"-DHAVE_SYSLOG_H",
"-DHAVE_PWRITE",
"-DHAVE_FCNTL",

I assume google's internal version uses blaze (?) and might have solved this?

@sergiud sergiud closed this as completed Mar 30, 2021
@sergiud sergiud mentioned this issue May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants