Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make EXPECT_THROW and EXPECT_NO_THROW macros more informative #2878

Closed
AmatanHead opened this issue Jun 4, 2020 · 4 comments
Closed

Make EXPECT_THROW and EXPECT_NO_THROW macros more informative #2878

AmatanHead opened this issue Jun 4, 2020 · 4 comments
Assignees

Comments

@AmatanHead
Copy link
Contributor

This is a continuation of #2071.

We could add catch case for std::exception to EXPECT_THROW to improve case when thrown exception is of an incompatible type.

If RTTI is available, we can also report the exact exception type by means of GetTypeName. This would further improve EXPECT_THROW and EXPECT_NO_THROW macros.

@CJ-Johnson
Copy link
Contributor

Thank you for the Issue report. Unfortunately, this is not an area of expertise for us. Could you provide a PR for this change?

@CJ-Johnson
Copy link
Contributor

The PR review is ongoing :)

@AmatanHead
Copy link
Contributor Author

@CJ-Johnson
Copy link
Contributor

My apologies. I mistook it for this one: #2904

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants