fix(snippetgen): remove special handling for resource paths #1134
Conversation
There are some bugs in this implementation that stop generation in some APIs and result in incorrect snippets getting generated for others. Back out this feature for now so it can be re-added later.
|
Which APIs are causing problems? If we can determine what the common factors are we could yank them into a test. |
Good idea, I'll open an issue that properly describes the issue. The current implementation can't handle fields that represent resources and are nested more than one level deep. This doesn't happen in any of the current golden APIs. IIRC I think it appeared in some AI/ML APIs with a bigger surface that define more resources. I made some progress towards fixing it in November, but am now having trouble figuring out what I had left to do 😅 . The snippetgen priorities for this quarter are (1) getting snippets into the docstrings and (2) generating metadata, so I decided to back this out to land the higher priority items first. |
|
I've opened an issue to track re-adding f-strings for resource paths #1144. Pub/Sub runs into the bug that halts generation and should be a good candidate for tests when I'm ready to work on this in the future. |
|
@software-dov Friendly ping |
busunkim96
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
I accidentally merged #1134 without updating the golden files for snippetgen. This PR updates the golden files and marks the 'snippetgen' check required.
🤖 I have created a release *beep* *boop* --- ## [0.62.0](v0.61.0...v0.62.0) (2022-01-28) ### Features * adds REST server-streaming support. ([#1120](#1120)) ([812cf3e](812cf3e)) * expose extended operations annotations within generator ([#1145](#1145)) ([e7bee70](e7bee70)) ### Bug Fixes * add special method parameters to set of reserved module names ([#1168](#1168)) ([8078961](8078961)) * fix snippetgen golden file ([#1170](#1170)) ([13b2028](13b2028)) * **snippetgen:** remove special handling for resource paths ([#1134](#1134)) ([4ea2d11](4ea2d11)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
There are some bugs in this implementation that stop generation
in some APIs and result in incorrect snippets getting generated
for others. Back out this feature for now so we can move forward
with enabling snippetgen for all APIs.