Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: require google-api-core 1.34.1 #1942

Merged
merged 7 commits into from
Feb 14, 2024
Merged

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Feb 13, 2024

test: fix rest streaming fragment test
chore: update dependencies in requirements.txt

Fixes #1940 🦕

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Feb 13, 2024
@parthea
Copy link
Contributor Author

parthea commented Feb 13, 2024

self = <google.api_core.rest_streaming.ResponseIterator object at 0x7ff861cdca50>

    def _grab(self):
        # Add extra quotes to make json.loads happy.
>       return self._response_message_cls.from_json(self._ready_objs.popleft())
E       AttributeError: from_json

This issue from the builld log was addressed in googleapis/python-api-core#604

@parthea parthea changed the title test: fix rest streaming fragment test fix: require google-api-core 1.34.1 Feb 14, 2024
@parthea parthea marked this pull request as ready for review February 14, 2024 17:14
@parthea parthea requested a review from a team as a code owner February 14, 2024 17:14
@parthea parthea merged commit 6c176a3 into main Feb 14, 2024
67 checks passed
@parthea parthea deleted the fix-rest-streaming-fragment-test branch February 14, 2024 17:54
@@ -0,0 +1,81 @@
// Copyright 2023 Google LLC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Date!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was copied from https://github.com/googleapis/googleapis/blob/master/google/api/httpbody.proto which is why I kept the date. It's not clear if we should update the date when the file is copied from another repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rpc in REST Streaming Fragment test is missing the http annotation
3 participants