Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix types on server and bidi streaming callables #641

Merged
merged 2 commits into from
Oct 8, 2020

Conversation

dpcollins-google
Copy link
Contributor

The return type is an Awaitable that produces an AsyncIterator.

@dpcollins-google dpcollins-google requested review from a team as code owners October 8, 2020 20:22
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 8, 2020
@codecov
Copy link

codecov bot commented Oct 8, 2020

Codecov Report

Merging #641 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #641   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines         1538      1538           
  Branches       310       310           
=========================================
  Hits          1538      1538           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 517118c...e27b9a3. Read the comment docs.

Copy link
Contributor

@lidizheng lidizheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR fixes a type annotation error I made. For bidi streaming calls, the asyncio application needs to explicitly invoke await to obtain the AsyncIterable responses (see example). This await is used to establish connection to peer, so the retry can happen immediately instead of being postponed till the first message read. LGTM.

@software-dov software-dov changed the title fix: Fix types on server and bidi streaming callables fix: fix types on server and bidi streaming callables Oct 8, 2020
@software-dov software-dov merged commit d92c202 into googleapis:master Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants