Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

fix: remove unused package option from java_gapic_library [gapic-generator] #3341

Merged
merged 2 commits into from
Feb 2, 2021

Conversation

miraleung
Copy link
Contributor

No description provided.

@miraleung miraleung requested a review from a team as a code owner February 1, 2021 23:25
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 1, 2021
Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #3341 (005a300) into master (267e4dd) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3341   +/-   ##
=========================================
  Coverage     87.14%   87.14%           
- Complexity     6120     6121    +1     
=========================================
  Files           495      495           
  Lines         24176    24176           
  Branches       2638     2638           
=========================================
+ Hits          21067    21068    +1     
  Misses         2242     2242           
+ Partials        867      866    -1     
Impacted Files Coverage Δ Complexity Δ
.../java/com/google/api/codegen/discovery/Schema.java 84.84% <0.00%> (+0.50%) 43.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 267e4dd...005a300. Read the comment docs.

@miraleung miraleung merged commit 857e2aa into master Feb 2, 2021
@miraleung miraleung deleted the miraleung-patch-4 branch February 2, 2021 21:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants