fix: incorrect compactor matcher in loki-deletion dashboard mixin

[QuentinBisson]

What this PR does / why we need it:

This PR fixes the loki-deletion dashboard compactor matcher for the SSD mixins

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

• Reviewed the CONTRIBUTING.md guide (required)
• Documentation added
• Tests updated
• Title matches the required conventional commits format, see here
• Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
• For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
• If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

[QuentinBisson]

@MichelHollands could you take a look?

[cstyan]

@QuentinBisson it's not clear to me why this is broken in the first place? job=namespace/loki-read should work for ssd

[QuentinBisson]

@cstyan I think you're right about the job but the container=compactor will definitely not work in ssd mode https://github.com/grafana/loki/pull/12567/files#diff-2e671957ef0b084f5abd5911a3ca6b92bc59b07dc8412477b13b2abac9fe1342L69

I took the matcher from

loki/production/loki-mixin/dashboards/loki-retention.libsonnet

Line 4 in eaa06f8

local compactor_pod_matcher = if $._config.ssd.enabled then 'container="loki", pod=~"%s-read.*"' % $._config.ssd.pod_prefix_matcher else 'container="compactor"',

but

loki/production/loki-mixin/dashboards/loki-retention.libsonnet

Line 5 in eaa06f8

local compactor_job_matcher = if $._config.ssd.enabled then '%s-read' % $._config.ssd.pod_prefix_matcher else 'compactor',

could also work

[cstyan]

@cstyan I think you're right about the job but the container=compactor will definitely not work in ssd mode https://github.com/grafana/loki/pull/12567/files#diff-2e671957ef0b084f5abd5911a3ca6b92bc59b07dc8412477b13b2abac9fe1342L69

I took the matcher from

loki/production/loki-mixin/dashboards/loki-retention.libsonnet

Line 4 in eaa06f8

local compactor_pod_matcher = if $._config.ssd.enabled then 'container="loki", pod=~"%s-read.*"' % $._config.ssd.pod_prefix_matcher else 'container="compactor"',

but

loki/production/loki-mixin/dashboards/loki-retention.libsonnet

Line 5 in eaa06f8

local compactor_job_matcher = if $._config.ssd.enabled then '%s-read' % $._config.ssd.pod_prefix_matcher else 'compactor',

could also work

oh fun, I didn't notice at first that we had different label selectors in panels of the same dashboard, lets use the same matcher as the retention dashboard which you have now

[cstyan]

this now needs a namespace label selector since we're not selecting on job=~"$namespace/%s" anymore

[QuentinBisson]

@cstyan this should be okay now :)

[cstyan]

@QuentinBisson thanks :)