Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add profile tagging to ingester #13068

Merged
merged 6 commits into from
May 31, 2024
Merged

feat: add profile tagging to ingester #13068

merged 6 commits into from
May 31, 2024

Conversation

slim-bean
Copy link
Collaborator

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

slim-bean and others added 2 commits May 30, 2024 16:00
@slim-bean @poyzannur
add profile tagging to ingester
021c9d6 
Signed-off-by: Edward Welch <edward.welch@grafana.com>
@poyzannur
add getChunkId, getStats, getVolume
dbfdaac
@poyzannur
Copy link
Contributor

I didn't think ParseMatchers were expensive enough to be in the profile labeller, but I'm happy to be proven otherwise.

cyriltovena
cyriltovena approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@slim-bean
also tag Label and Series requests
43a5573 
Signed-off-by: Edward Welch <edward.welch@grafana.com>
@slim-bean
also tag tenant ID
15dc84e 
Signed-off-by: Edward Welch <edward.welch@grafana.com>
@slim-bean slim-bean marked this pull request as ready for review May 30, 2024 20:29
@slim-bean slim-bean requested a review from a team as a code owner May 30, 2024 20:29
poyzannur
poyzannur reviewed May 30, 2024
View reviewed changes
pkg/ingester/ingester.go Outdated Show resolved Hide resolved
@poyzannur poyzannur merged commit 00d3c7a into main May 31, 2024
59 checks passed
@poyzannur poyzannur deleted the profile-tags branch May 31, 2024 12:26
@loki-gh-app loki-gh-app bot mentioned this pull request Jun 3, 2024
Closed
This was referenced Jun 10, 2024
Closed
Merged
slim-bean added a commit that referenced this pull request Jun 17, 2024
@slim-bean
Revert "feat: add profile tagging to ingester (#13068)"
4fedc0c 
This reverts commit 00d3c7a

Signed-off-by: Edward Welch <edward.welch@grafana.com>
slim-bean added a commit that referenced this pull request Jun 17, 2024
@slim-bean
Revert "feat: add profile tagging to ingester (#13068)"
986f4ce 
This reverts commit 00d3c7a

Signed-off-by: Edward Welch <edward.welch@grafana.com>
slim-bean added a commit that referenced this pull request Jun 17, 2024
@slim-bean
Revert "feat: add profile tagging to ingester (#13068)"
eccf6a3 
This reverts commit 00d3c7a

Signed-off-by: Edward Welch <edward.welch@grafana.com>
@loki-gh-app loki-gh-app bot mentioned this pull request Jun 24, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 1, 2024
Closed
@grafanabot grafanabot mentioned this pull request Jul 2, 2024
Open
This was referenced Jul 3, 2024
Closed
Closed
Closed
@RodrigoCMoraes RodrigoCMoraes mentioned this pull request Jul 12, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 15, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyzannur poyzannur poyzannur left review comments

@cyriltovena cyriltovena cyriltovena approved these changes

@paul1r paul1r paul1r approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@slim-bean @poyzannur @cyriltovena @paul1r