Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [release-3.1.x] feat(loki): add ability to disable AWS S3 dualstack endpoints usage #13795

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

vlad-diachenko
Copy link
Contributor

Backport bb257f5 from #13785


What this PR does / why we need it:
updated Thanos object client version to the latest which supports disabling AWS S3 dualstack endpoint usage.

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@vlad-diachenko vlad-diachenko added size/XXL backport type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories type/bug Somehing is not working as expected labels Aug 8, 2024
@vlad-diachenko vlad-diachenko requested a review from a team as a code owner August 8, 2024 07:11
@vlad-diachenko vlad-diachenko force-pushed the backport-13785-to-release-3.1.x branch 2 times, most recently from 408d800 to 0dda7da Compare August 8, 2024 07:35
…supports disabling AWS S3 dualstack endpoint usage.

Signed-off-by: Vladyslav Diachenko <vlad.diachenko@grafana.com>
@vlad-diachenko vlad-diachenko force-pushed the backport-13785-to-release-3.1.x branch from 0dda7da to 1aedf15 Compare August 8, 2024 08:25
@vlad-diachenko vlad-diachenko merged commit 464ac73 into release-3.1.x Aug 8, 2024
61 checks passed
@vlad-diachenko vlad-diachenko deleted the backport-13785-to-release-3.1.x branch August 8, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport size/XXL type/bug Somehing is not working as expected type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants