Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cloud-mixin): Attribute OTLP route correctly to write path #13943

Merged
merged 2 commits into from
Aug 21, 2024
Merged

fix(cloud-mixin): Attribute OTLP route correctly to write path #13943

merged 2 commits into from
Aug 21, 2024
+31 −32

Conversation

chaudum
Copy link
Contributor

@chaudum chaudum commented Aug 21, 2024 •
edited
Loading

What this PR does / why we need it:

The route /otlp/v1/logs is the OTLP endpoint for pushing logs, but it was attributed to the read path dashboard.

This commit moves the route from the reads dashboard to the writes dashboard.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@chaudum
fix(cloud-mixin): Attribute OTLP route correctly to write path
31470be 
The route `/otlp/v1/logs` is the OTLP endpoint for pushing logs, but it
was attributed to the read path dashboard.

This commit moves the route from the reads dashboard to the writes
dashboard.

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@chaudum
fixup! fix(cloud-mixin): Attribute OTLP route correctly to write path
1eeaf3c 
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@chaudum chaudum requested a review from a team as a code owner August 21, 2024 08:09
poyzannur
poyzannur approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@poyzannur poyzannur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ashwanthgoli
ashwanthgoli approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@ashwanthgoli ashwanthgoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaudum chaudum merged commit b91b782 into main Aug 21, 2024
63 checks passed
@chaudum chaudum deleted the chaudum/fix-loki-reads-dashboard branch August 21, 2024 08:17
@loki-gh-app loki-gh-app bot mentioned this pull request Sep 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwanthgoli ashwanthgoli ashwanthgoli approved these changes

@poyzannur poyzannur poyzannur approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chaudum @ashwanthgoli @poyzannur