feat(ingester): Smooth out chunk flush operations #9994
Merged
+35
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaudum
force-pushed
the
chaudum/smooth-out-flush-operations
branch
from
833ba75
to
d0a0bad
Compare
DylanGuedes
approved these changes
Jul 20, 2023
trevorwhitney
approved these changes
Jul 24, 2023
chaudum
force-pushed
the
chaudum/smooth-out-flush-operations
branch
from
37ac098
to
f18a57b
Compare
|
@chaudum I think this can land... |
chaudum
force-pushed
the
chaudum/smooth-out-flush-operations
branch
from
f18a57b
to
2a695c9
Compare
dannykopping
reviewed
Sep 4, 2023
In order to prevent spikes in chunk flush operations every flush check period, we smooth out the flush operations over the period of the interval. Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
chaudum
force-pushed
the
chaudum/smooth-out-flush-operations
branch
from
2a695c9
to
8359221
Compare
chaudum
changed the title
chaudum
changed the title
This was referenced Jul 8, 2024
This was referenced Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In order to prevent spikes in chunk flush operations every flush check period, we smooth out the flush operations over the period of the interval.
Special notes for your reviewer:
Taken from cortexproject/cortex#3191
Checklist
CONTRIBUTING.mdguide (required)CHANGELOG.mdupdatedadd-to-release-noteslabeldocs/sources/upgrading/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PR