Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migration to the new DKB frontend #42

Closed
grindsa opened this issue Jul 23, 2023 · 2 comments
Closed

migration to the new DKB frontend #42

grindsa opened this issue Jul 23, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@grindsa
Copy link
Owner

grindsa commented Jul 23, 2023

migration status

  • DKBRobo.account_dic() - ✅ - released with 0.23
  • DKBRobo.get_credit_limits() - ✅ - released with 0.25
  • DKBRobo.get_exemption_order()- ❌
  • DKBRobo.get_points() - ❌
  • DKBRobo.get_standing_orders()) - ✅ - released with 0.25
  • DKBRobo.get_transactions()-:white_check_mark: - released with 0.23
  • DKBRobo.last_login- ❌
  • DKBRobo.login() - ✅ - released with 0.22
  • DKBRobo.scan_postbox - ✅ - released with 0.25

breaking changes when migrating to the new frontend:

I am trying to ensure a certain level of backwards compatibility however there are a few changes you need to be aware when migrating to the new frontend.

general

  • default date format is changed to %Y-%m-%d

DKBRobo.account_dic()

  • account ordering is based on the new frontend
  • debit cards are shown in overview
  • IBANs are now represented without spaces
  • card numbers are masked
  • product groups (taken from UI) are shown in account overview
  • additional account attributes (currency code, limit)
  • additional card attributes (holder-name, status, expiry date)

DKBRobo.get_standing_orders()

  • account_dic[x]['id'] must be specified as input
  • data-structure changed (interval subtree added)

DKBRobo.get_transactions()

  • "mandatreferenz" and "customerreferenz" attributes will only be shown if available

DKBRobo.scan_postbox()

  • the document list provided in via API larger than shown in UI
  • so far only documents from categories "Kontoauszüge" and "Kreditabrechnungen" provided via API
@grindsa grindsa added the enhancement New feature or request label Jul 23, 2023
@grindsa grindsa self-assigned this Jul 23, 2023
@grindsa grindsa pinned this issue Jul 23, 2023
@grindsa
Copy link
Owner Author

grindsa commented Jul 24, 2023

The old frontend will be supported as long it is available. The plan is to use the legacy_login parameter switch between old and new frontend. I will also try to keep method names inside the DKBRobo() class the same. There might be some smaller changes (f.iiorder of accounts and cards in dkb.account_dic) but overall look and feel should stay more or less similar.

@grindsa grindsa changed the title migration status to the new DKB frontend migration to the new DKB frontend Oct 12, 2023
Repository owner deleted a comment from larmeh Oct 12, 2023
Repository owner deleted a comment from larmeh Oct 12, 2023
Repository owner locked and limited conversation to collaborators Oct 12, 2023
@grindsa
Copy link
Owner Author

grindsa commented Sep 18, 2024

closing as the old frontend got removed from library in v0.27

@grindsa grindsa closed this as completed Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant