fix: use drop valueOf when evaluated as solitary condition
#705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
admtnnr
force-pushed
the
fix/drop-condition-variable
branch
from
5db8a2b
to
f67e145
Compare
admtnnr
force-pushed
the
fix/drop-condition-variable
branch
from
f67e145
to
f63a690
Compare
|
@all-contributors please add @admtnnr for code |
|
🎉 This PR is included in version 10.14.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
I noticed an inconsistency with drops where a drop's value will go through normal value resolution if used in an expression like
if drop > 10, but it does not if the drop is the only part of the expression likeif dropwhich causes it to always evaluate as truthy (because it's an object).Shopify's Liquid implementation doesn't seem to support functionality similar to that of
valueOfthat we have in Liquid.js, so there's not prior art we can rely on there. Given if does seem to callvalueOfwhen used with some type of operator I opted to make the bare drop case consistent with the existing behavior.