Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should have documentation regarding expected code formatting / logic guidelines / explanation about the repos #120

Closed
OriHoch opened this issue Jan 20, 2017 · 5 comments

Comments

@OriHoch
Copy link
Collaborator

OriHoch commented Jan 20, 2017

No description provided.

@OriHoch
Copy link
Collaborator Author

OriHoch commented Jan 20, 2017

How to decide where to move existing code from open knesset?

  • You should always try to move as much as possible into the knesset-data pure python API - we should be as platform independent as possible.
  • However, the python API only handles stateless data flow - it gets some data from 3rd party (AKA Knesset) and forwards it with some processing as an output stream
  • code which requires a database or is too dependant on django infrastructure - should be in knesset-data-django
  • knesset-data-django contains platform dependant code, which usually means access to the Open Knesset Django models or some other Django specific dependency

@OriHoch
Copy link
Collaborator Author

OriHoch commented Feb 8, 2017

should consider all the knesset-data sub-projects: python / django / datapackage

@OriHoch OriHoch changed the title should have documentation regarding expected code formatting / logic guideliates should have documentation regarding expected code formatting / logic guidelines / explanation about the repos Mar 28, 2017
@OriHoch
Copy link
Collaborator Author

OriHoch commented Jun 11, 2017

linked to this issue from README

@OriHoch OriHoch closed this as completed Jun 11, 2017
@alonisser
Copy link
Contributor

Perhaps code formatting would be better served with an automated configuration file for code style check?

@OriHoch
Copy link
Collaborator Author

OriHoch commented Jun 18, 2017

yes, that'll be great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants