Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unnecessary search params #89

Merged
merged 1 commit into from
Oct 3, 2023
Merged

fix: remove unnecessary search params #89

merged 1 commit into from
Oct 3, 2023

Conversation

ansh-saini
Copy link
Contributor

Description

Fixes #83
I was able to identify three pages which made use of the arguments:

  • TimelinePage
  • GapsPage
  • SingleLineMapPage

I have made the following changes:

  • Distinguished the pages which need arguments
  • Remove empty arguments from the url. operatorId=&routeKey= etc...
  • Re-attached the arguments on pages which require them.

NoamGaash
NoamGaash approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, that's great!
you made it so clean and simple, thank you so much 🙏

@NoamGaash NoamGaash merged commit 16e4eac into hasadna:main Oct 3, 2023
4 checks passed
@github-actions github-actions bot mentioned this pull request Dec 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoamGaash NoamGaash NoamGaash approved these changes

Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

React routing | don't include redundant URL search arguments
2 participants
@ansh-saini @NoamGaash