fix: change unit of transaction value result #3057
Open
+11
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadezhdapopovaa
requested review from
AlfredoG87,
ebadiere,
lukelee-sl and
a team
as code owners
nadezhdapopovaa
force-pushed
the
3053-change-units-of-the-value-in-eth-gettransactionbyhash-result
branch
from
652a601
to
cadb710
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3057 +/- ##
===========================================
- Coverage 79.52% 43.55% -35.97%
===========================================
Files 60 50 -10
Lines 4044 3788 -256
Branches 814 787 -27
===========================================
- Hits 3216 1650 -1566
- Misses 551 1863 +1312
+ Partials 277 275 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nadezhdapopovaa
force-pushed
the
3053-change-units-of-the-value-in-eth-gettransactionbyhash-result
branch
from
c828f61
to
108c814
Compare
added 3 commits
October 7, 2024 15:42
Signed-off-by: Nadezhda Popova <nadezhdapopova@Nadezhdas-Work-MacBook-Pro.local>
Signed-off-by: Nadezhda Popova <nadezhdapopova@Nadezhdas-Work-MacBook-Pro.local>
Signed-off-by: Nadezhda Popova <nadezhdapopova@Nadezhdas-Work-MacBook-Pro.local>
nadezhdapopovaa
force-pushed
the
3053-change-units-of-the-value-in-eth-gettransactionbyhash-result
branch
from
108c814
to
e97dbd5
Compare
|
Nana-EC
reviewed
Oct 7, 2024
| @@ -176,7 +176,7 @@ const formatContractResult = (cr: any) => { | |||
| transactionIndex: nullableNumberTo0x(cr.transaction_index), | |||
| type: cr.type === null ? '0x0' : nanOrNumberTo0x(cr.type), | |||
| v: cr.v === null ? '0x0' : nanOrNumberTo0x(cr.v), | |||
| value: nanOrNumberTo0x(cr.amount), | |||
| value: nanOrNumberTo0x(cr.amount * constants.TINYBAR_TO_WEIBAR_COEF), | |||
There was a problem hiding this comment.
Make a util function for reusability, then you can add a test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Convert value of a transaction from tinybars to weibars for consistency.
Related issue(s):
Fixes #3053
Notes for reviewer:
Checklist