Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(TF-18664) Add DecodeReferenceOrigins and DecodeReferenceTargets jobs #1786

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented Aug 5, 2024

This commit adds two new jobs, DecodeReferenceOrigins and DecodeReferenceTargets, and their supporting plumbing to the stacks feature. These jobs are responsible for collecting reference origins and targets, respectively. Reference origins and targets are used to determine where a reference is defined and where it is used.

This information is useful for features like go-to-definition and go-to-references.

@jpogran jpogran self-assigned this Aug 5, 2024
This commit adds two new jobs, DecodeReferenceOrigins and DecodeReferenceTargets, and their supporting plumbing to the stacks feature. These jobs are responsible for collecting reference origins and targets, respectively. Reference origins and targets are used to determine where a reference is defined and where it is used.

This information is useful for features like go-to-definition and go-to-references.
@jpogran jpogran force-pushed the origins_references_plumbing branch from d7c280d to 35d10f3 Compare August 5, 2024 18:05
@ansgarm ansgarm force-pushed the origins_references_plumbing branch from c129e86 to e184e6d Compare August 6, 2024 15:19
@ansgarm ansgarm marked this pull request as ready for review August 6, 2024 15:20
@ansgarm ansgarm requested a review from a team as a code owner August 6, 2024 15:20
@ansgarm
Copy link
Member

ansgarm commented Aug 6, 2024

(fyi: ran go fmt, amended your last commit and force pushed to fix CI failing)

@ansgarm ansgarm changed the title Add DecodeReferenceOrigins and DecodeReferenceTargets jobs (TF-18664) Add DecodeReferenceOrigins and DecodeReferenceTargets jobs Aug 6, 2024
@ansgarm ansgarm merged commit 8e29bcf into pre-release Aug 6, 2024
7 checks passed
@ansgarm ansgarm deleted the origins_references_plumbing branch August 6, 2024 15:24
jpogran added a commit that referenced this pull request Aug 7, 2024
…#1786)

* Add DecodeReferenceOrigins and DecodeReferenceTargets jobs

This commit adds two new jobs, DecodeReferenceOrigins and DecodeReferenceTargets, and their supporting plumbing to the stacks feature. These jobs are responsible for collecting reference origins and targets, respectively. Reference origins and targets are used to determine where a reference is defined and where it is used.

This information is useful for features like go-to-definition and go-to-references.
jpogran added a commit that referenced this pull request Aug 30, 2024
…#1786)

* Add DecodeReferenceOrigins and DecodeReferenceTargets jobs

This commit adds two new jobs, DecodeReferenceOrigins and DecodeReferenceTargets, and their supporting plumbing to the stacks feature. These jobs are responsible for collecting reference origins and targets, respectively. Reference origins and targets are used to determine where a reference is defined and where it is used.

This information is useful for features like go-to-definition and go-to-references.
Copy link

github-actions bot commented Sep 6, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants