Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test toTitle_1stNotLower #332

Closed
Lysxia opened this issue May 2, 2021 · 1 comment · Fixed by #334
Closed

Failing test toTitle_1stNotLower #332

Lysxia opened this issue May 2, 2021 · 1 comment · Fixed by #334
Labels

Comments

@Lysxia
Copy link
Contributor

Lysxia commented May 2, 2021

I can reproduce it reliably by just raising the number of random test cases:

cabal test --test-options="--quickcheck-tests 10000 -p toTitle_1"
         t_toTitle_1stNotLower: FAIL
            *** Failed! Falsified (after 1299 tests and 7 shrinks):
            "\4317"

My current hypothesis is that the generated file src/Data/Text/Internal/Fusion/CaseMapping.hs is outdated (Unicode 9) compared to what base uses (Unicode 12). Can't we reuse functionality in base, possibly adding whatever is missing to base?

(This was also mentioned in passing in #326 (comment))

@Lysxia Lysxia added the bug label May 2, 2021
@Bodigrim
Copy link
Contributor

Bodigrim commented May 6, 2021

Regenerating case mapping would be nice, but it does not help in this case. See discussion at #302 (comment) One should exclude Georgian Extended chars from this test.

@Bodigrim Bodigrim linked a pull request May 8, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants