Skip to content

Commit

Permalink
[FAB-8769] Remove channel.Close
Browse files Browse the repository at this point in the history
Change-Id: I7084b1a4a2ecafa0b131f95e5430a3a86a93a22d
Signed-off-by: Troy Ronda <troy@troyronda.com>
  • Loading branch information
troyronda committed Mar 11, 2018
1 parent 60d97ee commit f0b5895
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 10 deletions.
8 changes: 0 additions & 8 deletions pkg/client/channel/chclient.go
Original file line number Diff line number Diff line change
Expand Up @@ -239,14 +239,6 @@ func (cc *Client) addDefaultTimeout(timeOutType core.TimeoutType, options ...Opt
return options
}

// Close ...
// TODO: This function should probably be deprecated since all
// resources (including caches) are on the providers and will
// be freed when Close() is called on the SDK.
func (cc *Client) Close() error {
return nil
}

// RegisterChaincodeEvent registers chain code event
// @param {chan bool} channel which receives event details when the event is complete
// @returns {object} object handle that should be used to unregister
Expand Down
2 changes: 0 additions & 2 deletions pkg/client/channel/chclient_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -365,8 +365,6 @@ func TestOrdererStatusError(t *testing.T) {
assert.EqualValues(t, status.ConnectionFailed, status.ToSDKStatusCode(statusError.Code))
assert.Equal(t, status.OrdererClientStatus, statusError.Group)
assert.Equal(t, testErrorMessage, statusError.Message, "Expected response message from server")

chClient.Close()
}

func TestTransactionValidationError(t *testing.T) {
Expand Down

0 comments on commit f0b5895

Please sign in to comment.