Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(peer): enable empty env variable #4309

Merged
merged 6 commits into from
Jul 13, 2023
Merged

feat(peer): enable empty env variable #4309

merged 6 commits into from
Jul 13, 2023

Conversation

yuriechan
Copy link
Contributor

@yuriechan yuriechan commented Jul 7, 2023 •
edited
Loading

Type of change

  • Improvement (improvement to code, performance, etc)

Description

Enable empty value to be set for environment variable, and not have it overwrite it with a default value.

Additional details

  • Pulled the viper configuration into a utility function
  • Added a viper configuration to allow empty env variables
  • Added a test that verifies empty env variables to take precedence over defaults

Related issues

None

Resolves #4076

@denyeart
Copy link
Contributor

denyeart commented Jul 8, 2023

Thank you for the contribution.

A few things that need to be resolved:

Please amend and re-push.

@yuriechan
add change and add unit tests
adfb341 
Signed-off-by: yuriechan <28754813+yuriechan@users.noreply.github.com>
@yuriechan
create separate function and add unit tests
f0873c3 
Signed-off-by: yuriechan <28754813+yuriechan@users.noreply.github.com>
@yuriechan
modify the unit test and the utility function
d3685b2 
Signed-off-by: yuriechan <28754813+yuriechan@users.noreply.github.com>
@yuriechan
resolve lint error
dfec16b 
Signed-off-by: yuriechan <28754813+yuriechan@users.noreply.github.com>
@yuriechan yuriechan marked this pull request as ready for review July 8, 2023 12:41
@yuriechan yuriechan requested a review from a team as a code owner July 8, 2023 12:41
@yuriechan yuriechan changed the title add change and add unit tests feat(peer): enable empty env variable Jul 8, 2023
@yuriechan
trigger ci
cd1376b 
Signed-off-by: yuriechan <28754813+yuriechan@users.noreply.github.com>
@yuriechan
trigger build
3971f6e 
Signed-off-by: yuriechan <28754813+yuriechan@users.noreply.github.com>
@yuriechan
Copy link
Contributor Author

@denyeart

Hi, I resolved your review comments.
Would it be possible for you to review the PR?

@yacovm yacovm merged commit 628d059 into hyperledger:main Jul 13, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yacovm yacovm yacovm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

peer: unable to disable core.vm.endpoint from env var
3 participants
@yuriechan @denyeart @yacovm