Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BFT Block Puller: seek content type "header+sig" to send full config blocks #4354

Closed
Tracked by #4240
tock-ibm opened this issue Aug 7, 2023 · 2 comments
Closed
Tracked by #4240
Assignees

Comments

@tock-ibm
Copy link
Contributor

tock-ibm commented Aug 7, 2023

  • When seek-info content type is "header+sig", send full config blocks, but data blocks with block.Data=nil.
  • Optimize IsConfigBlock() to return false fast when it is a block with more than 1 TX (the common case in high throughput networks). If there is 1 TX, go all the way to the channel header as usual.
@tock-ibm
Copy link
Contributor Author

tock-ibm commented Aug 21, 2023

To send config blocks, change the code at
common/deliver/deliver.go L331

Use protoutil.IsConfigBlock(block)

Optimize protoutil.IsConfigBlock(block) to return false early by looking if the number of TXs at the block.

@tock-ibm
Copy link
Contributor Author

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants