-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BFT Block Puller: a common block verifier #4408
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tock-ibm
force-pushed
the
bft-bp-block-verifier
branch
from
October 24, 2023 11:25
4049980
to
c313a1d
Compare
tock-ibm
force-pushed
the
bft-bp-block-verifier
branch
3 times, most recently
from
November 20, 2023 17:01
465287f
to
8e68eab
Compare
tock-ibm
force-pushed
the
bft-bp-block-verifier
branch
from
November 21, 2023 14:25
8e68eab
to
fa64d20
Compare
yacovm
reviewed
Nov 23, 2023
yacovm
reviewed
Nov 23, 2023
yacovm
reviewed
Nov 23, 2023
yacovm
reviewed
Nov 23, 2023
tock-ibm
force-pushed
the
bft-bp-block-verifier
branch
3 times, most recently
from
November 30, 2023 11:30
974d7a6
to
46ddfc7
Compare
tock-ibm
force-pushed
the
bft-bp-block-verifier
branch
from
November 30, 2023 12:42
46ddfc7
to
1562f0d
Compare
Signed-off-by: Yoav Tock <tock@il.ibm.com> Change-Id: I71aa3fd6f0ea0e4ea529614830ea95dfedb3cd36
Signed-off-by: May Rosenbaum <mayro1595@gmail.com> Signed-off-by: Yoav Tock <tock@il.ibm.com> Change-Id: I073a6086cbdb7cfa316b4a638cbb302b57e9d262
tock-ibm
force-pushed
the
bft-bp-block-verifier
branch
from
November 30, 2023 16:51
1562f0d
to
9bb4f00
Compare
merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
BFT Block Puller: a common block verifier to the peer the orderer.
The new implementation verifies the integrity and signatures of a block stream, while keeping a copy of the latest configuration.
Every time a config block arrives, it must first be verified using VerifyBlock and then used as an argument to the UpdateConfig method.
The block stream could be composed of either:
In both cases, config blocks must arrive in full.
This commit also moved
BlockVerifierAssembler
formorderer/common/cluster/util.go
tocommon/deliverclient/verifier_assembler.go
, as it is now used by both orderer and peer. In addition,VerificationRegistry
was removed fromorderer/common/cluster/util.go
as it is no longer in use.Related issues
#4346