Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BFT: orderer deliver handler: avoid mutating blocks #4456

Closed
Tracked by #4240
tock-ibm opened this issue Oct 2, 2023 · 0 comments
Closed
Tracked by #4240

BFT: orderer deliver handler: avoid mutating blocks #4456

tock-ibm opened this issue Oct 2, 2023 · 0 comments
Assignees
Labels

Comments

@tock-ibm
Copy link
Contributor

tock-ibm commented Oct 2, 2023

The orderer delivers blocks with block.Data=nil when asked for SeekInfo_HEADER_WITH_SIG.
However, with the introduction of a block cache, one needs to avoid mutating the block received from the block iterator, as those may be delivered to other peers that request full blocks.

@tock-ibm tock-ibm changed the title BFT: orderer deliver handler - avoid mutating blocks BFT: orderer deliver handler: avoid mutating blocks Oct 2, 2023
@tock-ibm tock-ibm self-assigned this Oct 2, 2023
@tock-ibm tock-ibm added the bug label Oct 2, 2023
@tock-ibm tock-ibm closed this as completed Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant