Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC / Update create_channel_test_net.md #4528

Closed
wants to merge 2 commits into from

Conversation

jannesklee
Copy link

The commit exhanges TwoOrgsApplicationGenesis with ChannelUsingRaft because of commit eb16ca in the fabric-sample repository.

Exchange TwoOrgsApplicationGenesis to ChannelUsingRaft

Signed-off-by: Jannes Klee <jannes.klee@proton.me>
@denyeart
Copy link
Contributor

denyeart commented Nov 6, 2023

Good catch, thank you!

I also see the same reference in docs/source/test_network.md and docs/source/create_channel/create_channel_config.md , do you want to update those in the same PR?

@jannesklee
Copy link
Author

I changed the according entries. Please be aware that within the create_channel_test_net-article the rest of the description of the configtx.yaml file does not seem to be up to date anymore.

The Capabilities and Applications are not mentioned in the description. The entry Etcdraft is now two times included, because it moved from Orderer to the Profiles section and I am not certain if the description is still correct (even if the block is removed).

@denyeart
Copy link
Contributor

denyeart commented Nov 7, 2023

I changed the according entries. Please be aware that within the create_channel_test_net-article the rest of the description of the configtx.yaml file does not seem to be up to date anymore.

The Capabilities and Applications are not mentioned in the description. The entry Etcdraft is now two times included, because it moved from Orderer to the Profiles section and I am not certain if the description is still correct (even if the block is removed).

Ok, thanks, I'll take a look.

@denyeart
Copy link
Contributor

denyeart commented Nov 7, 2023

One more thing, you'll need to sign the second commit as well to get the DCO check to pass, see https://github.com/hyperledger/fabric/pull/4528/checks?check_run_id=18410805423.

Alternatively, you can squash the two commits into a single signed commit. See https://hyperledger-fabric.readthedocs.io/en/latest/github/github.html#updating-a-pull-request.

@satota2
Copy link
Contributor

satota2 commented Dec 11, 2023

Hello.
I found that there are also sections in comments in fabric-samples that need to be revised.
So, I've created the following patch and submited it.
hyperledger/fabric-samples#1146

@denyeart
Copy link
Contributor

denyeart commented Apr 3, 2024

Ok, the doc changes have been made in #4781 and #4788, closing.

@denyeart denyeart closed this Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants