Block stream should be closed after used.

[datbeohbbh]

Current Status

fabric/common/ledger/blkstorage/blockfile_mgr.go

Lines 425 to 428 in 94590aa

	var stream *blockStream
	if stream, err = newBlockStream(mgr.rootDir, startFileNum, int64(startOffset), endFileNum); err != nil {
	return err
	}

A block stream is opened to sync block index. After used, we should close that block stream.

Expected

The block stream stream is closed after used.

Solution

simply add defer stream.close().

var stream *blockStream
if stream, err = newBlockStream(mgr.rootDir, startFileNum, int64(startOffset), endFileNum); err != nil {
	return err
}
defer stream.close() // close stream

Please let us know if you plan to work on this.

Maybe.