Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong ordinal for french locale #2010

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Conversation

ctessier
Copy link
Contributor

@ctessier ctessier commented Aug 4, 2022

In french, when writing dates, there is no ordinal for numbers over 1.

  • lundi 1er août 2022 ✔️
  • jeudi 11 août 2022 ✔️
  • jeudi 11e août 2022 ❌

In other contexts, this could be correct, but not for dates.
See for instance on this French website of the government : https://www.service-public.fr/particuliers/actualites

@xavier-villelegier
Copy link

For more context: this is basically a revert of the regression introduced by this PR #1932 in the v1.11.4

@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #2010 (3d84e16) into dev (b5b7be1) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               dev     #2010   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          181       181           
  Lines         2074      2074           
  Branches       544       544           
=========================================
  Hits          2074      2074           
Impacted Files Coverage Δ
src/locale/fr.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@iamkun
Copy link
Owner

iamkun commented Aug 12, 2022

Thanks, let's get it to revert to the original one

@iamkun iamkun merged commit dd192a7 into iamkun:dev Aug 12, 2022
iamkun pushed a commit that referenced this pull request Aug 12, 2022
## [1.11.5](v1.11.4...v1.11.5) (2022-08-12)

### Bug Fixes

* ordinal for nl not working ([#2011](#2011)) ([c93c85e](c93c85e))
* wrong ordinal for french locale ([#2010](#2010)) ([dd192a7](dd192a7))
@iamkun
Copy link
Owner

iamkun commented Aug 12, 2022

🎉 This PR is included in version 1.11.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

BePo65 pushed a commit to BePo65/dayjs that referenced this pull request Oct 10, 2022
## [1.11.5](iamkun/dayjs@v1.11.4...v1.11.5) (2022-08-12)

### Bug Fixes

* ordinal for nl not working ([iamkun#2011](iamkun#2011)) ([c93c85e](iamkun@c93c85e))
* wrong ordinal for french locale ([iamkun#2010](iamkun#2010)) ([dd192a7](iamkun@dd192a7))
ohsory1324 pushed a commit to ohsory1324/dayjs that referenced this pull request Dec 20, 2023
## [1.11.5](iamkun/dayjs@v1.11.4...v1.11.5) (2022-08-12)

### Bug Fixes

* ordinal for nl not working ([iamkun#2011](iamkun#2011)) ([c93c85e](iamkun@c93c85e))
* wrong ordinal for french locale ([iamkun#2010](iamkun#2010)) ([dd192a7](iamkun@dd192a7))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants