direct eval warning when bundling with esbuild

[leebenmorris]

When building code for Cypress using esbuild and this plugin I get the following warning:

Warning: G] Using direct eval with a bundler is not recommended and may cause problems [direct-eval]

node-modules-polyfills:crypto:28833:9:
  28833 │   return eval((this || _global$b).code);
        ╵          ~~~~

You can read more about direct eval and bundling here: https://esbuild.github.io/link/direct-eval

Should I be concerned about this?

[imranbarbhuiya]

This lib doesn't provide the source code of these modules. It depends on https://github.com/Aslemammad/modern-node-polyfills
which uses https://github.com/jspm/jspm-core I search their source code but can't find any usage of eval. I'll look into it.

Also, if u are bundling only for testing, ig you can ignore this warning, but this can cause issues for production bundles.

Can you give me a minimal repro of this issue?

Edit: last time I used GitHub search, it didn't show me the eval as the crypto file is too large. So this time I downloaded the file and found the code

  (Script.prototype.runInThisContext = function () {
    return eval((this || _global$b).code);
  }),

I'm not sure how to fix this as it's present in upstream code. If anyone has any idea about fixing this issue, then lmk

[imranbarbhuiya]

For now, I fixed in my lib and published v1.0.14, if it gets fixed in upstream, I'll revert my changes