-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dialog: Missing role and focus handling #401
Comments
@basham, these are rivet-react Dialog component bugs. Also, it looks like the focus issues are not present on adobe react-spectrum, so they appear to be an issue with our Dialog component (FWIW: Admittedly I didn’t test how the focus works) |
For the last couple weeks, I've been exploring if we could use the native However, it seems like the current recommendation of the Digital Accessibility Office is to not use this
Given this, we agreed during today's meeting that we will just continue with the current |
I'm testing the Dialog component, and I noticed some accessibility issues.
role="dialog"
should always be applied to the dialog. It is missing whendisablePageInteraction
is enabled.The text was updated successfully, but these errors were encountered: