Improve SplitMap deserialization. Make interning stricter #2675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current deserialization for Map is a bit dumb: first it deserializes into a list, which is then reversed and only after that it is converted to a
Map. It makes sense only for preservation of semantics of deserialization in presence of duplicate keys. For UTxO we know for sure there will never be any duplicate TxIns, which means that we can construct a Map as it is being deserialized thus avoiding intermediate list allocations, which saves memory and about 20% in deserialization time.This PR also reduces memory overhead during deserialization by making internin a little stricter