Fix "UTxO entry too small" check. #2722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #2644 refactored these checks, but also made the change from `not $ Val.pointwise (>=)` to `Val.pointwise (<)`. However, since `pointwise` is basically acting as `all` here, these checks are not equivalent. The former will return `True` on e.g. `[0, 0] [0, 1]`, but the latter will not (since 0 is not less than 0). This commit restores the original test.
lehins
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #2644 refactored these checks, but also made the change from
not $ Val.pointwise (>=)toVal.pointwise (<). However, sincepointwiseis basically acting as
allhere, these checks are not equivalent. Theformer will return
Trueon e.g.[0, 0] [0, 1], but the latter willnot (since 0 is not less than 0).
This commit restores the original test.