Remove Show for PlutusDebug and disable traceEvent on PlutusScriptResult #2772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
force-pushed
the
lehins/disable-plutus-debug-tracing
branch
from
06f377e
to
18aa400
Compare
JaredCorduan
approved these changes
May 7, 2022
There was a problem hiding this comment.
fantastic catch @lehins ! I don't think anyone depends on showing the script result in the trace, I think it is just used for gathering statistics.
I'd love to know how we missed this in our earlier profiles (using db-analyze). 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TimSheard and I discovered that it is really expensive to
traceEventthat involvesPlutusDebug, because showing that type is way too inefficient (naturally due to theStringtype and the size of the type).This PR simply disables showing the
ScriptResultin the event log tracing. If this is an unacceptable solution we need discuss a better one. However, adding the huge debug trace for every script even if it is only for profiling is unacceptable, because it affects our ability to argue about performance of running a script, since showing thePlutusDebugwill dominate the overhead.Also this PR intentionally removes the Show instance, to prevent future temptation of relying on it.