Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a constant to babbageMinUTxOValue computation #2821

Merged
merged 2 commits into from
May 26, 2022

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented May 25, 2022

When using TxOut serialization size for minUTxO value, we did not account for the overhead that comes from TxIn and Map data structure that is used for keeping TxOut in memeory.

This PR fixes this problem by adding a constant of 160 bytes. See comment in the PR for more info.

Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lehins lehins merged commit e366ea9 into master May 26, 2022
@iohk-bors iohk-bors bot deleted the lehins/add-constant-to-minutxo branch May 26, 2022 09:56
@JaredCorduan
Copy link
Contributor

We expect this PR to resolve IntersectMBO/cardano-node#3913

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants