the alonzo UTxO rule to use alonzo minfee function #2938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally, a new golden test for the alonzo fee calculation has been added, using the block from: IntersectMBO/cardano-node#4228 (comment)
teodanciu
reviewed
Jul 28, 2022
teodanciu
approved these changes
Jul 28, 2022
There was a problem hiding this comment.
Diffing the diffs, I noticed that this PR adds HasField "txrdmrs" (Core.Witnesses era) (Redeemers era) to feesOK function, whereas #2936 didn't.
Also, in #2936, HasField "_prices" was added as constraints to utxoTransition and STS (AlonzoUTXO era) instance, whereas in this PR we're only adding it to feesOK. Perhaps these are necessary because of the other changes that were left behind on this branch!
The rest looks the same to me 👍
|
I am going to merge, even though |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry picks the commit from #2936 for the release branch
release/1.0.0. The cherry pick required a bit of massaging due to the glorious recent cleanup in #2901, but can be compared line by line with #2936 to check that is is semantically the same.