Relax overly strict disconnection rule for known-invalid blocks #3726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the context of diffusion pipelining, it is possible honest behavior for an upstream peer to send us a block that we already know is invalid by the time we process the RollForward message (e.g. because we already received it from another peer and finished validating it).
dcoutts
approved these changes
Apr 29, 2022
Comment on lines
731
to
735
| unless (isPipeliningEnabled version) $ do | ||
| -- Reject the block if invalid | ||
| isInvalidBlock <- atomically $ forgetFingerprint <$> getIsInvalidBlock | ||
| whenJust (isInvalidBlock hdrHash) $ \reason -> | ||
| disconnect $ InvalidBlock hdrPoint reason |
There was a problem hiding this comment.
We still check for extending invalid chains though right?
There was a problem hiding this comment.
There was a problem hiding this comment.
Hmm, I don't think it's reliable to use the Watcher for this.
There was a problem hiding this comment.
Update: While we don't think it is strictly necessary, I will go ahead and add a check that at this place in the code that ensures that the parent hash is not known-invalid.
nfrisby
requested changes
Apr 29, 2022
ouroboros-consensus/src/Ouroboros/Consensus/MiniProtocol/ChainSync/Client.hs
Outdated
Show resolved
Hide resolved
amesgen
force-pushed
the
amesgen/CAD-4225-relax-overly-strict-chain-sync-client-disconnection-rule
branch
from
e4eccd7
to
d1b4d34
Compare
nfrisby
approved these changes
May 2, 2022
ouroboros-consensus/src/Ouroboros/Consensus/MiniProtocol/ChainSync/Client.hs
Outdated
Show resolved
Hide resolved
amesgen
force-pushed
the
amesgen/CAD-4225-relax-overly-strict-chain-sync-client-disconnection-rule
branch
from
d1b4d34
to
2c1fcd1
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
May 2, 2022
3726: Relax overly strict disconnection rule for known-invalid blocks r=amesgen a=amesgen Closes [CAD-4225](https://input-output.atlassian.net/browse/CAD-4225) Co-authored-by: Alexander Esgen <alexander.esgen@iohk.io>
|
Build failed: |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
May 3, 2022
3726: Relax overly strict disconnection rule for known-invalid blocks r=amesgen a=amesgen Closes [CAD-4225](https://input-output.atlassian.net/browse/CAD-4225) Co-authored-by: Alexander Esgen <alexander.esgen@iohk.io>
|
Timed out. |
|
bors r+ |
iohk-bors
bot
deleted the
amesgen/CAD-4225-relax-overly-strict-chain-sync-client-disconnection-rule
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes CAD-4225