Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coverage tests for the diffusion test suite #3728

Merged
merged 14 commits into from
May 20, 2022
Merged

Coverage tests for the diffusion test suite #3728

merged 14 commits into from
May 20, 2022
+822 −22

Conversation

bolt12
Copy link
Contributor

@bolt12 bolt12 commented May 2, 2022

No description provided.

@bolt12 bolt12 requested a review from coot as a code owner May 2, 2022 09:26
This was linked to issues May 2, 2022
Coverage test for various network conditions in diffusion simulation #3329
Closed
Coverage test for diffusion traces #3328
Closed
@bolt12 bolt12 changed the base branch from master to bolt12/diffusion-public May 2, 2022 17:18
@bolt12 bolt12 force-pushed the bolt12/diffusion-coverage branch from a8ce701 to 0a8d5a7 Compare May 3, 2022 12:38
@bolt12 bolt12 force-pushed the bolt12/diffusion-coverage branch from 0a8d5a7 to 2363b3c Compare May 5, 2022 14:35
@coot
Copy link
Contributor

coot commented May 6, 2022

it seems that CI failed

@bolt12
Copy link
Contributor Author

bolt12 commented May 6, 2022

It was hydra with a cache failure, I am not really sure how I can ask it to re-run

@bolt12 bolt12 force-pushed the bolt12/diffusion-coverage branch from 2363b3c to a4bd30c Compare May 6, 2022 10:57
@bolt12 bolt12 force-pushed the bolt12/diffusion-coverage branch from a4bd30c to e7f3635 Compare May 6, 2022 13:32
@bolt12 bolt12 force-pushed the bolt12/diffusion-coverage branch from e7f3635 to aef2e69 Compare May 6, 2022 15:52
@bolt12 bolt12 force-pushed the bolt12/diffusion-coverage branch from aef2e69 to 771aba0 Compare May 9, 2022 11:27
@bolt12 bolt12 force-pushed the bolt12/diffusion-coverage branch from 771aba0 to 71bcf4e Compare May 17, 2022 11:05
@bolt12 bolt12 requested a review from coot May 17, 2022 11:07
@bolt12 bolt12 force-pushed the bolt12/diffusion-coverage branch from 71bcf4e to 531ee87 Compare May 17, 2022 16:10
@bolt12 bolt12 force-pushed the bolt12/diffusion-coverage branch from 531ee87 to 64ca5bb Compare May 18, 2022 11:17
@bolt12 bolt12 force-pushed the bolt12/diffusion-coverage branch from 64ca5bb to 4e31bf4 Compare May 18, 2022 16:00
coot
coot approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bolt12 bolt12 changed the base branch from bolt12/diffusion-public to master May 19, 2022 16:03
@bolt12
Copy link
Contributor Author

bolt12 commented May 19, 2022

bors merge

iohk-bors bot added a commit that referenced this pull request May 19, 2022
@iohk-bors @bolt12
Merge #3728
53eb5cd 
3728: Coverage tests for the diffusion test suite r=bolt12 a=bolt12



Co-authored-by: Armando Santos <armando@well-typed.com>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 19, 2022

Build failed:

@bolt12
Copy link
Contributor Author

bolt12 commented May 19, 2022

bors retry

iohk-bors bot added a commit that referenced this pull request May 19, 2022
@iohk-bors @bolt12
Merge #3728
082fd69 
3728: Coverage tests for the diffusion test suite r=bolt12 a=bolt12



Co-authored-by: Armando Santos <armando@well-typed.com>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 19, 2022

Build failed:

@bolt12
Copy link
Contributor Author

bolt12 commented May 19, 2022

bors retry

@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 20, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit dfa2697 into master May 20, 2022
@iohk-bors iohk-bors bot deleted the bolt12/diffusion-coverage branch May 20, 2022 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coot coot coot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Coverage test for various network conditions in diffusion simulation Coverage test for diffusion traces
2 participants
@bolt12 @coot