Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various changes #3736

Merged
merged 5 commits into from
May 20, 2022
Merged

Various changes #3736

merged 5 commits into from
May 20, 2022

Conversation

coot
Copy link
Contributor

@coot coot commented May 9, 2022

  • io-sim-por: delete terminated threads
  • removed TipSample protocol
  • ouroboros-network: renamed ouroboros-protocol-tests component
  • typed-protocols: fixed a typo
  • block-fetch: typos
  • ouroboros-network:test Fix a typo
  • ouroboros-network-framework: align the code

@coot coot added networking io-sim Issues related to io-sim and io-sim-classes. labels May 9, 2022
@coot coot requested a review from bolt12 May 9, 2022 10:19
@bolt12
Copy link
Contributor

bolt12 commented May 9, 2022

CI error, seems like an import that no longer exists

@coot
Copy link
Contributor Author

coot commented May 17, 2022

bors merge

iohk-bors bot added a commit that referenced this pull request May 17, 2022
@iohk-bors @coot
Merge #3736
ef722fc 
3736: Various changes r=coot a=coot

- io-sim-por: delete terminated threads
- removed TipSample protocol
- ouroboros-network: renamed ouroboros-protocol-tests component
- typed-protocols: fixed a typo
- block-fetch: typos
- ouroboros-network:test Fix a typo
- ouroboros-network-framework: align the code


Co-authored-by: Marcin Szamotulski <coot@coot.me>
Co-authored-by: Marcin Szamotulski <profunctor@pm.me>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 17, 2022

Build failed:

@coot coot requested review from newhoggy, a team, njd42 and nfrisby as code owners May 19, 2022 10:11
@coot
Copy link
Contributor Author

coot commented May 19, 2022 •
edited
Loading

Requires #3747 (rebased on top of it).

@coot
Copy link
Contributor Author

coot commented May 19, 2022

bors merge

@coot
Copy link
Contributor Author

coot commented May 19, 2022

bors halt

@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 19, 2022

Canceled.

@coot
Copy link
Contributor Author

coot commented May 20, 2022

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 20, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit 13e8b47 into master May 20, 2022
@iohk-bors iohk-bors bot deleted the coot/small-changes branch May 20, 2022 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bolt12 bolt12 bolt12 approved these changes

@newhoggy newhoggy Awaiting requested review from newhoggy

@njd42 njd42 Awaiting requested review from njd42

@nfrisby nfrisby Awaiting requested review from nfrisby

Assignees
No one assigned
Labels
io-sim Issues related to io-sim and io-sim-classes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coot @bolt12