From e58cdfc652c72f22120060ecba0f69fcdd04f2db Mon Sep 17 00:00:00 2001 From: Andrei Elovikov Date: Tue, 19 Mar 2024 15:20:40 -0700 Subject: [PATCH 1/2] [CI] Create Github Job Summary for failing E2E tasks Unfortunately, our E2E tests use custom LIT format so I wasn't able to make `llvm-lit` generate the results into a JSON file. That meant that I have to redirect the entire output into a log file and Github Actions won't be able to show intermediate progress until `llvm-lit` finishes execution. Another thing worth mentioning is that these summaries aren't "searchable" via Github's search queries (unlike comments), but I think it's still a usability improvement because it would allow to see all the failures on a single page. --- .github/workflows/sycl-linux-run-tests.yml | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/.github/workflows/sycl-linux-run-tests.yml b/.github/workflows/sycl-linux-run-tests.yml index 1db9951bcf0c4..f8d8ee84db3e5 100644 --- a/.github/workflows/sycl-linux-run-tests.yml +++ b/.github/workflows/sycl-linux-run-tests.yml @@ -268,12 +268,19 @@ jobs: run: | cmake -GNinja -B./build-e2e -S./llvm/sycl/test-e2e -DSYCL_TEST_E2E_TARGETS="${{ inputs.target_devices }}" -DCMAKE_CXX_COMPILER="$(which clang++)" -DLLVM_LIT="$PWD/llvm/llvm/utils/lit/lit.py" ${{ steps.cmake_opts.outputs.opts }} - name: SYCL End-to-end tests + shell: bash {0} if: inputs.tests_selector == 'e2e' env: LIT_OPTS: -v --no-progress-bar --show-unsupported --show-pass --show-xfail --max-time 3600 --time-tests ${{ inputs.extra_lit_opts }} run: | - ninja -C build-e2e check-sycl-e2e - + ninja -C build-e2e check-sycl-e2e > e2e.log 2>&1 + exit_code=$? + cat e2e.log + if [ $exit_code -ne 0 ]; then + # TODO: XPASS/UNRESOLVED + awk '/Failed Tests|Testing Time/{flag=1}/FAILED: CMakeFiles/{flag=0}flag' e2e.log >> $GITHUB_STEP_SUMMARY + fi + exit $exit_code - name: Build SYCL CTS tests if: inputs.tests_selector == 'cts' env: From 5eb1ea0eeb6655a4dcdc7f932697250738cd57fe Mon Sep 17 00:00:00 2001 From: aelovikov-intel Date: Tue, 19 Mar 2024 20:32:57 -0700 Subject: [PATCH 2/2] Update .github/workflows/sycl-linux-run-tests.yml --- .github/workflows/sycl-linux-run-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/sycl-linux-run-tests.yml b/.github/workflows/sycl-linux-run-tests.yml index f8d8ee84db3e5..bafcc23e07b2f 100644 --- a/.github/workflows/sycl-linux-run-tests.yml +++ b/.github/workflows/sycl-linux-run-tests.yml @@ -278,7 +278,7 @@ jobs: cat e2e.log if [ $exit_code -ne 0 ]; then # TODO: XPASS/UNRESOLVED - awk '/Failed Tests|Testing Time/{flag=1}/FAILED: CMakeFiles/{flag=0}flag' e2e.log >> $GITHUB_STEP_SUMMARY + awk '/^Failed Tests|Testing Time/{flag=1}/FAILED: CMakeFiles/{flag=0}flag' e2e.log >> $GITHUB_STEP_SUMMARY fi exit $exit_code - name: Build SYCL CTS tests