feat(constants): update model constants

[francois-caddet]

Description

• Add new models Mistral Nemo and Codestral Mamba
• Add aliases to models constant to be deserialized seemlessly from the versioned forme (e.g.: "mistral-large-2407")
• The commonly named Mistral Large 2 is now constants::Model::MistralLargeLatest when the old one is Model::MistralLarge

Checklist

• I updated the tests accordingly. Or I don't need to.

[coderabbitai]

Walkthrough

The changes involve modifications to the Model enum in the src/v1/constants.rs file. New variants, including OpenMistralNemo, MistralLarge, and CodestralMamba, have been added. Existing variants such as MistralSmallLatest, MistralMediumLatest, MistralLargeLatest, and CodestralLatest have been updated to include version-specific aliases for serialization purposes.

Changes

Files	Change Summary
src/v1/constants.rs	Addition of new variants: OpenMistralNemo, MistralLarge, and CodestralMamba. Modifications to existing variants to include aliases for MistralSmallLatest, MistralMediumLatest, MistralLargeLatest, and CodestralLatest.
tests/v1_constants_test.rs	Addition of tests for new model constants: Model::OpenMistralNemo, Model::MistralLarge, and Model::CodestralMamba.

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between 43973c1 and 3b83916.

Files selected for processing (1)

• tests/v1_constants_test.rs (1 hunks)

Additional comments not posted (3)

tests/v1_constants_test.rs (3)

14-14: Addition of Model::OpenMistralNemo to test constants.

This addition is consistent with the PR's objective to enhance model testing. Ensure that all references and usages of this new model are updated across the codebase.

---

19-19: Addition of Model::MistralLarge to test constants.

This addition reflects the renaming of Mistral Large 2 to Model::MistralLargeLatest and retaining the previous version as Model::MistralLarge. It's important to verify that this renaming does not affect other parts of the codebase where the model might be referenced.

Run the following script to verify the renaming and ensure all references are updated:

---

21-21: Addition of Model::CodestralMamba to test constants.

This new model should be thoroughly tested, and its integration into the codebase should be checked for any potential issues, especially in match statements that might not have a default case.

Run the following script to check for potential issues in match statements:

Verification successful

---

No match statements found for Model::CodestralMamba.

The addition of Model::CodestralMamba appears only in the test file and is not involved in any match statements in the codebase. Therefore, there are no potential issues with match statements that require handling of this new model.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for match statements handling `Model::CodestralMamba`.

# Test: Search for match statements that might need updating. Expect: Match statements with a default case or handling the new model.
rg --type rust -A 5 $'match.*Model.*{'

Length of output: 133

---

Script:

#!/bin/bash
# Description: Check for match statements handling `Model::CodestralMamba`.

# Test: Search for match statements that might need updating. Expect: Match statements with a default case or handling the new model.
rg --type rust -A 5 $'match.*Model.*\\{'

Length of output: 40

---

Script:

#!/bin/bash
# Description: Search for direct usage of `Model::CodestralMamba` in the codebase.

# Test: Find occurrences of `Model::CodestralMamba` to verify its handling.
rg --type rust 'Model::CodestralMamba'

Length of output: 96

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[ivangabriele]

Tks, I didn't know the alias attr ^^.

1. It's not breaking since none of the current models are deleted, it's just additions ;). I updated the title.
2. It's worth updating units tests (v1_constants_test.rs) to be sure all the model names are working.

[francois-caddet]

The addition of an enum variant can actualy break match blocks if they don't have a default match arm.

Ok I'll update the tests.

[ivangabriele]

Thank you! I'll merge this one and release it for a start.