Add retry_if_exception_match

[PhML]

As there is retry_if_exception_type, would it be possible to have retry_if_exception_match?
It would replace :

retry_if_exception(lambda e: re.match(pattern, str(e)))

by:

retry_if_exception_match(pattern)

[immerrr]

It could be nicer to extend the existing retry_if_exception to accept match kwarg, like pytest.raises does:

retry_if_exception(MyException, match='zzz')
retry_if_exception(MyException, match=some_precompiled_regexp)

[PhML]

@immerrr I thought about it but since there were already retry_if_exception_type I didn't want to suggest a different convention. Otherwise, it would be more coherent to have:

retry_if_exception(type=MyException)
retry_if_exception(match="pattern")

and so on.
But I think that the purpose of retry_if_exception is to be a base class not a specialized one.

[Brian-Williams]

I think having a separate classes is a good idea because it gives greater granularity for use cases where several retry predicates need to be chained.

It allows you to do things like separating exception type from exception message.

retry=(retry_if_exception_type=MyException1 | retry_if_exception_message(match=r'a[bc]*'))

vs.

retry=(retry_if_exception_type=MyException1 & retry_if_exception_message(match=r'a[bc]*'))

Then even if exception MyException2 raises with errormessage 'ab' it will retry.

@jd Any interest in this? I put together a rough sketch of what it could look like here.

[jd]

@Brian-Williams That sounds like a good idea. Feel free to send a PR.

[jamesbraza]

Should this issue be closed? I think it was resolved