Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In icicle mode, the bar at bottom should really be at the top #176

Closed
itamarst opened this issue Jun 3, 2020 · 4 comments · Fixed by #177
Closed

In icicle mode, the bar at bottom should really be at the top #176

itamarst opened this issue Jun 3, 2020 · 4 comments · Fixed by #177

Comments

@itamarst
Copy link
Contributor

itamarst commented Jun 3, 2020

When you mouseover a frame there's a little bar at the bottom of the diagram that shows info like "33% of samples" or "20% of RAM" or whatever.

In icicle mode most of the interesting info is at the top, and so you never actually get to see this bar if you have a long callstack. This is pretty much always the case for my use case—see e.g. https://pythonspeed.com/products/filmemoryprofiler/memory-graph.svg, where the really tall callstack on the left means you never get to see the bottom bar.

It seems that for icicle mode this bar should always be at the top.

I will attempt to write a PR for this.

@jonhoo
Copy link
Owner

jonhoo commented Jun 3, 2020

Oh, yes, good catch! I wonder if this is the case for the official flamegraph too then — we re-use basically the same code as them. May be worth checking if anything has changed in their code, or if there are outstanding PRs there on this issue. Would very much like a PR here though regardless!

@itamarst
Copy link
Contributor Author

itamarst commented Jun 3, 2020

Their code looks the same, and not seeing any PRs/issues.

@itamarst
Copy link
Contributor Author

itamarst commented Jun 3, 2020

https://pythonspeed.com/products/filmemoryprofiler/ is how I'm using Inferno, BTW.

@jonhoo
Copy link
Owner

jonhoo commented Jun 3, 2020

Thanks for checking! And that's neat — thanks for linking it :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants