Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox rendering bug for SVGs #241

Closed
itamarst opened this issue May 15, 2022 · 0 comments · Fixed by #242
Closed

Firefox rendering bug for SVGs #241

itamarst opened this issue May 15, 2022 · 0 comments · Fixed by #242

Comments

@itamarst
Copy link
Contributor

itamarst commented May 15, 2022

In Firefox there appears to be a race condition where sometimes the height of the flamegraph is not updated fast enough, and so the browser renders it with too large of a height. Here you see two graphs stacked above each other; notice the whitespace between them that shouldn't be there:

Screenshot from 2022-05-15 15-36-23

If I reload the page, the gap (usually) disappears.

The solution I came up with, which I need to test further (it's an intermittent bug...) is to move the viewpoint DOM manipulation until after the new width was created, i.e. svg.removeAttribute("viewBox"); gets moved to the end of update_for_width_change(). I will do some more verification, and if it really fixes the bug, submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant