From 3c111d3a87d56dca7d1773c6e5b85a1aae7448c4 Mon Sep 17 00:00:00 2001 From: "Blades, Stephen" Date: Thu, 24 Mar 2022 07:43:58 -0500 Subject: [PATCH] feat: default events prop to an empty array Changes to default props to no longer make events required, defaulting to an empty array #1708 --- .husky/pre-commit | 2 +- src/Calendar.js | 4 +++- stories/props/API.stories.mdx | 3 ++- stories/props/events.mdx | 3 ++- stories/props/events.stories.js | 2 +- 5 files changed, 9 insertions(+), 5 deletions(-) diff --git a/.husky/pre-commit b/.husky/pre-commit index 36af21989..1e696a4fe 100755 --- a/.husky/pre-commit +++ b/.husky/pre-commit @@ -1,4 +1,4 @@ #!/bin/sh . "$(dirname "$0")/_/husky.sh" -npx lint-staged +NODE_ENV=development npx lint-staged diff --git a/src/Calendar.js b/src/Calendar.js index 72fbaa58f..c67e43548 100644 --- a/src/Calendar.js +++ b/src/Calendar.js @@ -845,6 +845,8 @@ class Calendar extends React.Component { } static defaultProps = { + events: [], + backgroundEvents: [], elementProps: {}, popup: false, toolbar: true, @@ -981,7 +983,7 @@ class Calendar extends React.Component { view, toolbar, events, - backgroundEvents = [], + backgroundEvents, style, className, elementProps, diff --git a/stories/props/API.stories.mdx b/stories/props/API.stories.mdx index c0393b758..d9d46ecbb 100644 --- a/stories/props/API.stories.mdx +++ b/stories/props/API.stories.mdx @@ -150,7 +150,8 @@ Callback fired when the `view` value changes. When included it is used to 'contr ### events -- type: `arrayOf(Event)` **required** +- type: `arrayOf(Event)` +- default: `[]` - Example diff --git a/stories/props/events.mdx b/stories/props/events.mdx index 016550e40..95290d521 100644 --- a/stories/props/events.mdx +++ b/stories/props/events.mdx @@ -2,7 +2,8 @@ import { Canvas, Story } from '@storybook/addon-docs' # events -- type: `arrayOf(Event)` **required** +- type: `arrayOf(Event)` +- default: `[]` An array of event objects to display on the calendar. Events objects can be any shape, as long as the Calendar knows how to retrieve the diff --git a/stories/props/events.stories.js b/stories/props/events.stories.js index 9e0a019ff..355ae783d 100644 --- a/stories/props/events.stories.js +++ b/stories/props/events.stories.js @@ -31,7 +31,7 @@ const Template = (args) => ( ) export const Events = Template.bind({}) -Events.storyName = 'events *' +Events.storyName = 'events' Events.args = { defaultDate: new Date(2015, 3, 13), events: demoEvents,