Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: regression with cookie header case sensivity #193

Closed
TorstenDittmann opened this issue Oct 11, 2024 · 1 comment · Fixed by #194
Closed

bug: regression with cookie header case sensivity #193

TorstenDittmann opened this issue Oct 11, 2024 · 1 comment · Fixed by #194

Comments

@TorstenDittmann
Copy link
Contributor

TorstenDittmann commented Oct 11, 2024

Starting version 1.0.0, setting cookie headers are now case sensitive. Meaning passing Lax as sameSite will not work anymore.

Before 1.0.0 it was changed to lowercase before the condition => https://github.com/jshttp/cookie/blob/v0.7.2/index.js#L273C1-L274C51

When consumed directly it is safe by types, however in my case the library is consumed and used by a dependency.

Bildschirmfoto 2024-10-11 um 14 35 16
@TorstenDittmann TorstenDittmann changed the title bug: regression for cookie header case sensivity bug: regression with cookie header case sensivity Oct 11, 2024
@TorstenDittmann
Copy link
Contributor Author

Found this too late #189. I still think it might be useful to have this fallback, in my case I have no control over what my auth library is passing to the underlying framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant