Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG:: false positive react/no-unused-prop-types #944

Closed
sagiavinash opened this issue Nov 6, 2016 · 2 comments
Closed

BUG:: false positive react/no-unused-prop-types #944

sagiavinash opened this issue Nov 6, 2016 · 2 comments

Comments

@sagiavinash
Copy link

sagiavinash commented Nov 6, 2016

in following scenarios react/no-unused-prop-types is triggered falsely

  1. if a particular prop is only accessed via nextProps then its not being considered as usage
  • in my use case i am referring in componentWillReceiveProps(nextProps)
  1. sometimes if a prop is read only via es6 destructuring then its not being considered as usage
  • const { dataPoint } = this.props;
  1. if a prop is referred inside a array.map callback then usage is not detected.
@teameh
Copy link
Contributor

teameh commented Nov 15, 2016

Duplicate of at least #811 (your 1.) #814 (your 1.) and #819 (your 3.)

@DianaSuvorova
Copy link
Contributor

First 2 are fixed. For the 3rd there are nuances.But the simplest array.map use cases are supported Need to close this ticket. Thanks!

@ljharb ljharb closed this as completed Jul 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants