Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong react/jsx-indent since 6.7.0 #966

Closed
ibc opened this issue Nov 19, 2016 · 0 comments
Closed

Wrong react/jsx-indent since 6.7.0 #966

ibc opened this issue Nov 19, 2016 · 0 comments
Labels

Comments

@ibc
Copy link

ibc commented Nov 19, 2016

Using eslint-plugin-react 6.2.1, eslint does not complain about the following JSX code:

	{!state.localHold ?
		<PauseIcon
			onClick={this.handleHold.bind(this)}
		/>
	:
		<ResumeIcon
			onClick={this.handleResume.bind(this)}
		/>
	}

However, using 6.7.1, eslint complains:

93:9 error Expected indentation of 9 tab characters but found 8  (react/jsx-indent)

NOTE: line 93 is the one containing <ResumeIcon.

However, if I do the following, eslint does not complain:

	{!state.localHold ?
		<PauseIcon
			onClick={this.handleHold.bind(this)}
		/>
	:
			<ResumeIcon
				onClick={this.handleResume.bind(this)}
			/>
	}

This is obviously weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants