Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix loading of local notebooks with url special characters in path #353

Merged
merged 2 commits into from
Apr 7, 2021
Merged

Fix loading of local notebooks with url special characters in path #353

merged 2 commits into from
Apr 7, 2021

Conversation

bgerrity
Copy link
Contributor

@bgerrity bgerrity commented Apr 5, 2021 •
edited
Loading

Aligns behavior with the comment and fixes the issue.

kevin-bates
kevin-bates reviewed Apr 6, 2021
View reviewed changes
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes sense - thank you.

Could you please add a test for this? Seems like just renaming one of the notebooks used as a seed may be sufficient.

kevin-bates
kevin-bates approved these changes Apr 7, 2021
View reviewed changes
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding the test and this contribution. I believe the test failures are unrelated.
(This repo could use some TLC!)

@kevin-bates kevin-bates merged commit d780ef7 into jupyter-server:master Apr 7, 2021
@blink1073 blink1073 added this to the 2.5 milestone Apr 19, 2021
@kevin-bates kevin-bates mentioned this pull request May 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin-bates kevin-bates kevin-bates approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5
Development

Successfully merging this pull request may close these issues.
3 participants
@bgerrity @kevin-bates @blink1073