Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docker version #444

Merged
merged 7 commits into from
May 20, 2023
Merged

fix: docker version #444

merged 7 commits into from
May 20, 2023

Conversation

AlexsJones
Copy link
Member

Closes #

πŸ“‘ Description

βœ… Checks

  • [x ] My pull request adheres to the code style of this project
  • [x ] My code requires changes to the documentation
  • [x ] I have updated the documentation as required
  • [x ] All the tests have passed

β„Ή Additional Information

#430 #434

Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
@AlexsJones AlexsJones requested review from a team as code owners May 19, 2023 08:38
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Copy link
Contributor

@matthisholleville matthisholleville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexsJones AlexsJones enabled auto-merge (squash) May 19, 2023 17:15
thschue
thschue previously approved these changes May 19, 2023
Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
@AlexsJones AlexsJones dismissed stale reviews from thschue and matthisholleville via a449755 May 19, 2023 20:52
@AlexsJones AlexsJones disabled auto-merge May 20, 2023 19:31
@AlexsJones AlexsJones merged commit 1f767eb into main May 20, 2023
@AlexsJones AlexsJones deleted the fix/docker-version branch May 20, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants