You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Network Attachment Definition CRD name (and singular/plural names) network-attachment-definitions.k8s.cni.cncf.io contains dashes, something that I don't believe is common in Kubernetes resource type naming (just try running kubectl api-resources | cut -d ' ' -f 1 and then look for items with dashes...).
The obvious fix would be to change the actual CRD names.
However, it's important to keep in mind that such a change could potentially break various things downstream (if they're "delicate" enough)... This could be partially mitigated by adding pseudo-backwards-compatibility by supporting the "old" (with dashes) plural/singular names via the shortNames list.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
The Network Attachment Definition CRD name (and singular/plural names)
network-attachment-definitions.k8s.cni.cncf.io
contains dashes, something that I don't believe is common in Kubernetes resource type naming (just try runningkubectl api-resources | cut -d ' ' -f 1
and then look for items with dashes...).The obvious fix would be to change the actual CRD names.
However, it's important to keep in mind that such a change could potentially break various things downstream (if they're "delicate" enough)... This could be partially mitigated by adding pseudo-backwards-compatibility by supporting the "old" (with dashes) plural/singular names via the
shortNames
list.Here is my suggested implementation in the YAML:
This is far from a critical issue, but still worth bringing up IMHO...
Some additional info on CRD naming conventions and defaults can be reviewed in these reference docs.
Beta Was this translation helpful? Give feedback.
All reactions